[Webkit-unassigned] [Bug 23818] Fix mix of unicode and ansi functions in PluginDatabaseWin.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 8 03:47:12 PST 2009


------- Comment #5 from camaradetux at gmail.com  2009-02-08 03:47 PDT -------
(In reply to comment #4)
> (From update of attachment 27448 [review])
> This patch doesn't look right to me.  The functions you are renaming are not
> ANSI - e.g. SHGetValue is a macro defined to either SHGetValueA or SHGetValueW,
> depending on whether UNICODE is defined. The same is true of the TEXT macro.
> I'm not a huge Windows expert, but I'm sufficiently sure about these macros'
> behavior to say r-. But please feel free to mark this for review again if I'm
> actually wrong.

Right, by "mix" I actually meant "potential mix", when UNICODE is not defined.

Of course it's possible to use the macros everywhere but not trying to restore
ansi and only having unicode looked like the right choice. 

So the question is : do we want to restore the possibility to use the ansi
version of these functions or should we go unicode-only ?

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list