[Webkit-unassigned] [Bug 23818] Fix mix of unicode and ansi functions in PluginDatabaseWin.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 8 02:23:04 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23818


ap at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27448|review?                     |review-
               Flag|                            |




------- Comment #4 from ap at webkit.org  2009-02-08 02:23 PDT -------
(From update of attachment 27448)
This patch doesn't look right to me.  The functions you are renaming are not
ANSI - e.g. SHGetValue is a macro defined to either SHGetValueA or SHGetValueW,
depending on whether UNICODE is defined. The same is true of the TEXT macro.

I'm not a huge Windows expert, but I'm sufficiently sure about these macros'
behavior to say r-. But please feel free to mark this for review again if I'm
actually wrong.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list