[Webkit-unassigned] [Bug 3248] Mouse events on OPTION element seem to be ignored

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Feb 7 11:13:03 PST 2009


darin at apple.com changed:

           What    |Removed                     |Added
  Attachment #27444|review?                     |review+
               Flag|                            |

------- Comment #14 from darin at apple.com  2009-02-07 11:13 PDT -------
(From update of attachment 27444)
I still think that size_t and calling size() on listItems directly would be
slightly better in RenderListBox::nodeAtPoint. I also would not bother with a
local variable for the result of itemBoundingBoxRect and I would have put the
declaration of "node" inside the if statement, and called it element rather
than node. But these are tiny nits. Good new test!

I also think it's unfortunate that we use offsetX/Y at all, since they have a
crazy definition. I bet we could make the code easier to understand if we used
pageX/Y instead some day. For now, fix is great, r=me!


Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list