[Webkit-unassigned] [Bug 23788] call style()->isOriginalDisplayInlineType() on RenderBox

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23788


rwlbuis at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27396|review?                     |review+
               Flag|                            |




------- Comment #2 from rwlbuis at gmail.com  2009-02-07 06:43 PDT -------
(From update of attachment 27396)
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog	(revision 40718)
> +++ WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,13 @@
> +2009-02-06  Zalan Bujtas  <zbujtas at gmail.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +        
> +        https://bugs.webkit.org/show_bug.cgi?id=23788
> +        call style()->isOriginalDisplayInlineType() on RenderBox instead of RenderObject. 
> +        
> +        * rendering/bidi.cpp:
> +        (WebCore::RenderBlock::skipLeadingWhitespace):
> +
>  2009-02-06  Simon Hausmann  <simon.hausmann at nokia.com>
>  
>          Reviewed by Tor Arne Vestbø.
> Index: WebCore/rendering/bidi.cpp
> ===================================================================
> --- WebCore/rendering/bidi.cpp	(revision 40717)
> +++ WebCore/rendering/bidi.cpp	(working copy)
> @@ -1480,7 +1480,7 @@ int RenderBlock::skipLeadingWhitespace(I
>      
>              RenderBox* box = toRenderBox(object);
>              if (box->style()->hasStaticX()) {
> -                if (object->style()->isOriginalDisplayInlineType())
> +                if (box->style()->isOriginalDisplayInlineType())
>                      box->layer()->setStaticX(style()->direction() == LTR ? leftOffset(height(), firstLine) : width() - rightOffset(height(), firstLine));
>                  else
>                      box->layer()->setStaticX(style()->direction() == LTR ? borderLeft() + paddingLeft() : borderRight() + paddingRight());

AFAICS the end result is the same, but indeed confusing to use object here. r =
me


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.