[Webkit-unassigned] [Bug 23772] Should LayoutTests/http/tests/history/redirect-js-form-submit-before-load-expected.txt be passing or failing?

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 6 14:57:21 PST 2009


------- Comment #4 from ggaren at apple.com  2009-02-06 14:57 PDT -------
Happy to clarify.

A layout test passes if you run it and your results match the expected results
.txt (or .png) file. That tells you that you haven't inadvertently changed

Almost all of the time, the expected results will say "PASS" -- as you'd

Sometimes, though, it's useful to write a layout test that documents current
behavior, even though you think the current behavior is not so good. It's
useful because the test can still catch inadvertent changes in behavior. We
call such a test an "expected failure."

I've been doing a bit of work lately in the history code, so I wrote some
layout tests to make sure that I didn't inadvertently change behavior. For many
of the tests, I thought that WebKit's current behavior was not so good, so I
checked in a result that said "FAIL." These tests are expected failures.

Ideally, we'll fix these expected failures in the future -- probably after some
broader discussion of what behavior we want.  Then, the tests will start saying
"PASS," and we'll change the expected test results to match.

Sorry if that confused you. Maybe there's a better way to do things --
honestly, I didn't think about it all that much.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list