[Webkit-unassigned] [Bug 23776] Introduce 2 base classes to split WorkerMessaingProxy.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 6 02:56:44 PST 2009


levin at chromium.org changed:

           What    |Removed                     |Added
                 CC|                            |levin at chromium.org

------- Comment #2 from levin at chromium.org  2009-02-06 02:56 PDT -------
  WorkerMessaingProxy sp

   // A proxy to talk to the worker context.
I'm not sure that this comment adds much info.

  // Creator.
This comment should be omitted.

   static WorkerContextProxyBase* create(const String& scriptURL, Worker*
The param "worker" doesn't add any info so it should be omited.

Also I don't think this method is implemented yet, so it probably shouldn't be

Lastly, it bring up lifetime issues.  Is this class deleted by who ever creates
it.  I suspect the lifetime will be more like WorkerMessagingProxy and this
class will need a method like "void workerObjectDestroyed();"  (something to
signal the class that the WorkerObject is done with it).

The per method comments throughout seem to repeat the method name and should
just be omitted.

The vcproj file references .cpp files that aren't part of the patch.

I think GNUMakefile.am needs to have the header files added to it.  

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list