[Webkit-unassigned] [Bug 16135] [GTK] Support caret browsing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=16135





------- Comment #9 from xan.lopez at gmail.com  2009-02-05 03:34 PDT -------
(In reply to comment #8)
> (From update of attachment 27073 [review])
> The g_thread_init () change doesn't belong in this patch.

Right, it was needed for GtkLauncher to run though. I did it so Sun guys could
test it and give feedback (but apparently they never got to it).

> 
> I think this is all good as long as it doesn't change behaviour on other ports.
> Maybe with a ChangeLog entry we can get this reviewed (I'd best not review my
> own code!)
> 
> Cheers
> 

I tried to be careful to make it so that the new code is never executed if the
caret pref is not enabled, so it should be safe. I can add the ChangeLog if you
think this could go in already, but there are still some quite important things
missing (see previous comments).


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.