[Webkit-unassigned] [Bug 23452] Add XHTMLMP support to Webkit

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23452





------- Comment #5 from yichao.yin at torchmobile.com.cn  2009-02-04 19:04 PDT -------
Hi Dave,
Thanks for your good comments. my reply is below.

(In reply to comment #4)
> (From update of attachment 27307 [review])
> The code here:
> if (m_doc->isXHTMLDocument() && !m_hasDocTypeDeclaration) {
> ... bails if you don't have a DOCTYPE.  It only asks if you're an XHTML
> document, so if XHTMLMP is enabled, you'll start being more strict in your
> handling of XHTML documents that aren't also the XHTMLMP MIME type.  Is that
> what you really want?

You are right, we'd better add Document::isXHTMLMPDocument() to check this.


> The code in parseDTD and externalSubsetHandler had lines like:
> (publicId == QLatin1String("-//WAPFORUM//DTD XHTML Mobile 1.0//EN"))) {
> These were unconditionally removed.  Shouldn't those just be left alone but put
> inside #if !ENABLE(XHTMLMP)?

Yes, sorry to ignore it, will fix them. :-)

> The new document method isXHTMLDocument() was added inside #if ENABLE(XHTMLMP).
>  It's ok for that to be outside of the #ifdef.

Will replace this method with isXHTMLMPDocument().

> Can you explain what the NOSCRIPT changes are about? Why do you need an actual
> element for <noscript> in the XHTMLMP case?
> Thanks!

As per the specification: OMA-WAP-XHTMLMP-V1_1-20061020-A.pdf, XHTML Mobile
profile is a strict subset of XHTML 1.1 [XHTML11]. It extends XHTML Basic
[XHTMLBasic] to bring enhanced functionality to application authors, including
"scripts within a document", and <noscript> is a new elment in the scripts
module, which is used to describe an alternate presentation for use. It's
defined in this DTD document:
http://www.w3.org/TR/xhtml-modularization/DTD/xhtml-script-1.mod

Usually, there are two situations the <noscript> should be processed.
1) when any <script> elements can't be excuted because of the language
specified by its type attribute is invalid.
2) scripting is not supported by the user agent or is configured to not
evaluate scripts by user.

I will upload the updated patch soon.
Thanks againg


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.