[Webkit-unassigned] [Bug 23741] New: StyleRareNonInheritedData::operator==() should not compare ContentData objects by pointer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 4 14:08:46 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=23741

           Summary: StyleRareNonInheritedData::operator==() should not
                    compare ContentData objects by pointer
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Macintosh
               URL: http://trac.webkit.org/browser/trunk/WebCore/rendering/s
                    tyle/StyleRareNonInheritedData.cpp#L97
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: CSS
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ddkilzer at webkit.org
                CC: hyatt at apple.com


* SUMMARY
Using the power of code inspection, I discovered that
StyleRareNonInheritedData::operator==() was comparing ContentData objects by
pointer instead of using RenderStyle::contentDataEquivalent().

The RenderStyle::contentDataEquivalent() method needs to move to
StyleRareNonInheritedData:: contentDataEquivalent() and
StyleRareNonInheritedData::operator==() should start using it.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.



More information about the webkit-unassigned mailing list