[Webkit-unassigned] [Bug 23625] Skia platform doesn't render text to a canvas or support clipping to an image buffer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 4 10:40:54 PST 2009


sky at google.com changed:

           What    |Removed                     |Added
  Attachment #27298|0                           |1
        is obsolete|                            |
  Attachment #27319|                            |review?(eric at webkit.org)
               Flag|                            |

------- Comment #12 from sky at google.com  2009-02-04 10:40 PDT -------
Created an attachment (id=27319)
 --> (https://bugs.webkit.org/attachment.cgi?id=27319&action=view)
Fixes three bugs introduced in first patch

This fixes three bugs found in the first patch:

. When a new layer was started clipped to an image we used the
  assignment operator to copy the SkBitmap. If the SkBitmap owns it's
  pixels, this is not the right thing to do. Instead we need to create
  a copy of the image.
. State holds an SkBitmap by value. State's copy constructor does a
  memcpy. This is confusing and subtle, I've converted to use a member
  initializer list which I think is clearer and less error prone.
. When creating a new layer there is no need to copy the clip image.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

More information about the webkit-unassigned mailing list