[Webkit-unassigned] [Bug 23496] execCommand('bold') will remove <b style='font-style:italic'>, it should probably replace it with <span style='font-style:italic'

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23496





------- Comment #9 from eric at webkit.org  2009-02-04 09:50 PDT -------
(In reply to comment #8)
> The double-bold case is still not fixed.  It's not made worse either by this
> change, but I may yet have the stamina for one more round of debugging for that
> case.

I realized last night why the double-bold case is broken.

void
ApplyStyleCommand::replaceWithSpanOrRemoveIfWithoutAttributes(HTMLElement*&
elem)

is supposed to update the "elem" pointer so that the caller knows what the
element has turned into, and can continue processing it.  When I updated that
function to use an editing command (so i would be undoable), I lost that
functionality.  I'm not quite sure how I should get it back yet.

I could add a ::spanElement() accessor on the command, but I don't think that
will work well in the undo case, not sure.  Starting to seem like I'll need to
test undo of this command too.  I'd still be very interested in Justin's
comment here.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.