[Webkit-unassigned] [Bug 23395] Web Inpsector Debugger's Source List Should Be Sorted

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23395


timothy at hatcher.name changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #26827|review?                     |review+
               Flag|                            |




------- Comment #9 from timothy at hatcher.name  2009-02-03 13:22 PDT -------
(From update of attachment 26827)
The code looks fine, but there are some coding style inconsistencies.

> +        if (select.childNodes)
> +        {

Brace should be on the same line as the if.

> +    while (first <= last)
> +    {

Brace should be on the same line as the while.

> +        else
> +        {

Brace should be on the same line as the else.

> +    return -first-1;

Should be spaces around the subtraction minus sign.

I will fix these up when I land the patch, since I feel bad for letting this
sit in review so long.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.