[Webkit-unassigned] [Bug 23607] REGRESSION: Clicking near an contentEditable div will focus the div, even though it shouldn't!

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23607





------- Comment #14 from justin.garcia at apple.com  2009-02-02 17:35 PDT -------
> The editing delegate changes are not well understood

The change in:

/LayoutTests/platform/mac/editing/selection/select-all-iframe-expected.txt

comes from your fix for 23605 (the x position of the caret that's created is
close to where the mouseDown occurred now instead of after the line of text). 
So that's fine.

But, the change in:

/LayoutTests/platform/mac/editing/selection/select-from-textfield-outwards-expected.txt

leads me to believe that the patch may have caused a regression in behavior
when you click inside a text field and drag-select up.  It looks like for a
particular position above the textfield, we create the wrong selection.  Check
out line 25 of select-from-textfield-outwards:

eventSender.mouseMoveTo(middleX, middleY - field.offsetHeight);

It looks like that used to correspond to this:

EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of #text > DIV to
12 of #text > DIV toDOMRange:range from 0 of #text > DIV to 12 of #text > DIV
affinity:NSSelectionAffinityDownstream stillSelecting:FALSE

which is being replaced by:

EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of #text > DIV to
12 of #text > DIV toDOMRange:range from 11 of #text > DIV to 17 of #text > DIV
affinity:NSSelectionAffinityDownstream stillSelecting:FALSE

which doesn't seem right.

Also I think:

+// FIXME: This function should could go on RenderObject an instance method
then
+// all cases in which positionForCoordinates recurses could call this instead
to

should perhaps read "...should go in an RenderObject instance method, then...".


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.