[Webkit-unassigned] [Bug 23653] PopupMenuChromium.h could be cleaned-up

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23653


eric at webkit.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27190|review?                     |review+
               Flag|                            |




------- Comment #2 from eric at webkit.org  2009-02-02 14:36 PDT -------
(From update of attachment 27190)
This looks fine.

 1 2009-01-29  Jay Campan  <set EMAIL_ADDRESS environment variable>

Your EMAIL_ADDRESS is missing.

Wrong spacing:
+static const PopupContainerSettings dropDownSettings = {
+  true, // focusOnShow
+  true, // setTextOnIndexChange
+  true, // acceptOnAbandon
+  false // loopSelectionNavigation
+};

This looks fine.  Can be fixed on commit.


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.