[Webkit-unassigned] [Bug 23684] New: Endless loop for image with zero duration frame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23684

           Summary: Endless loop for image with zero duration frame
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Images
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: lyon.chen at torchmobile.com
                CC: treat at kde.org


In function BitmapImage::startAnimation(), there's a potential endless loop
when the duration of frames is zero, which can be observed in aircanada.com for
its searching page.

Following is the verified fix:

diff --git a/WebCore/platform/graphics/BitmapImage.cpp
b/WebCore/platform/graphics/BitmapImage.cpp
index 45b32ab..e3ef8b0 100644
--- a/WebCore/platform/graphics/BitmapImage.cpp
+++ b/WebCore/platform/graphics/BitmapImage.cpp
@@ -323,6 +323,10 @@ void BitmapImage::startAnimation(bool catchUpIfNecessary)
             if (time < frameAfterNextStartTime)
                 break;

+            /* Is the frame duration is zero, which means we should not
animate! */
+            if (frameAfterNextStartTime == m_desiredFrameStartTime)
+                break;
+
             // Yes; skip over it without notifying our observers.
             if (!internalAdvanceAnimation(true))
                 return;


-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.