[Webkit-unassigned] [Bug 33087] [V8] Separate DOMWrapperWorld from V8IsolatedWorld

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33087


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #4 from WebKit Review Bot <webkit.review.bot at gmail.com>  2009-12-31 10:40:57 PST ---
Attachment 45718 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/bindings/v8/V8IsolatedContext.cpp:37:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.cpp:64:  context_scope is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
WebCore/bindings/v8/V8IsolatedContext.h:36:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.h:39:  Alphabetical sorting problem. 
[build/include_order] [4]
WebCore/bindings/v8/V8IsolatedContext.h:40:  One space before end of line
comments  [whitespace/comments] [5]
WebCore/bindings/v8/V8IsolatedContext.h:73:  Use 0 instead of NULL. 
[readability/null] [4]
WebCore/bindings/v8/V8IsolatedContext.h:107:  isolated_world is incorrectly
named. Don't use underscores in your identifier names.  [readability/naming]
[4]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.cpp': Can't open for
reading
WebCore/bindings/v8/MainThreadDOMData.cpp:57:  Tests for true/false,
null/non-null, and zero/non-zero should all be done without equality
comparisons.  [readability/comparison_to_zero] [5]
Skipping input 'WebCore/bindings/v8/V8IsolatedWorld.h': Can't open for reading
Total errors found: 8

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.