[Webkit-unassigned] [Bug 33056] Implement NO_RETURN for MSVC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33056





--- Comment #6 from Patrick R. Gansterer <paroga at paroga.com>  2009-12-31 00:04:46 PST ---
(In reply to comment #5)
> (From update of attachment 45670 [details])
> Given that the function is not intended to return I’m not sure why we’d want to
> remove the annotation that indicates that.  Anyway, this will break the Mac
> build (and possibly others):
> JavaScriptCore/wtf/FastMalloc.cpp:1431: warning: function might be possible
> candidate for attribute ‘noreturn’
When you implement NO_RETURN for MSVC then it will throw an warning, because
noreturn functions must have a void return type. A solution might be that we
disable "warning C4646: function declared with __declspec(noreturn) has
non-void return type", but then is the problem with the compiler for WinCE. It
seams that it ignores the noreturn and throws always an error!

The other possible solution is, that we don't implement NO_RETURN for MSVC and
copy the hack from FastMalloc.cpp to jsc.cpp (see bug 32939). I think that this
will win, because GCC is the better/prefered compiler. ;-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.