[Webkit-unassigned] [Bug 30883] [Gtk] Implement AtkText for HTML elements which contain text

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30883


Joanmarie Diggs <joanmarie.diggs at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45696|                            |review?
               Flag|                            |




--- Comment #4 from Joanmarie Diggs <joanmarie.diggs at gmail.com>  2009-12-30 19:47:46 PST ---
Created an attachment (id=45696)
 --> (https://bugs.webkit.org/attachment.cgi?id=45696)
proposed patch

This is the bulk of it (and it might be all of it):

* Implements AtkText for HTML elements which contain text
* Eliminates the now-extraneous objects of ROLE_TEXT from the hierarchy
* get_text_{after,at,before}_offset and get_text work as expected
* Layout tests for accessibility are verified to continue to work as expected
* Unit tests for accessibility updated and verified to work as expected

Still on the to-do list:

1. Verify that events work as expected -- and if not, fix that
2. Add a new unit test or two

However as this patch is complete (and MUCH needed and has two bugs now
depending upon it), a review would be most appreciated. Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.