[Webkit-unassigned] [Bug 33065] Chromium Linux: add support for per-strike font render preferences

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33065


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2009-12-30 13:26:24 PST ---
Attachment 45681 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebCore/platform/graphics/chromium/FontRenderStyle.h:42:  One space before end
of line comments  [whitespace/comments] [5]
WebCore/platform/graphics/chromium/FontRenderStyle.h:44:  One space before end
of line comments  [whitespace/comments] [5]
WebCore/platform/graphics/chromium/FontRenderStyle.h:45:  One space before end
of line comments  [whitespace/comments] [5]
WebCore/platform/graphics/chromium/FontRenderStyle.h:46:  One space before end
of line comments  [whitespace/comments] [5]
WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp:142:  One line
control clauses should not use braces.  [whitespace/braces] [4]
WebCore/platform/graphics/chromium/FontPlatformDataLinux.cpp:201:  Tests for
true/false, null/non-null, and zero/non-zero should all be done without
equality comparisons.  [readability/comparison_to_zero] [5]
WebKit/chromium/public/linux/WebFontRenderStyle.h:62:  #endif line should be
"#endif // WebFontRenderStyle_h"  [build/header_guard] [5]
WebKit/chromium/public/linux/WebFontRenderStyle.h:45:  One space before end of
line comments  [whitespace/comments] [5]
WebKit/chromium/public/linux/WebFontRenderStyle.h:47:  One space before end of
line comments  [whitespace/comments] [5]
WebKit/chromium/public/linux/WebFontRenderStyle.h:48:  One space before end of
line comments  [whitespace/comments] [5]
WebKit/chromium/public/linux/WebFontRenderStyle.h:49:  One space before end of
line comments  [whitespace/comments] [5]
WebKit/chromium/src/gtk/WebFontInfo.cpp:110:  is_bold is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/chromium/src/gtk/WebFontInfo.cpp:111:  is_italic is incorrectly named.
Don't use underscores in your identifier names.  [readability/naming] [4]
WebKit/chromium/src/gtk/WebFontInfo.cpp:143:  Use 0 instead of NULL. 
[readability/null] [4]
WebKit/chromium/src/ChromiumBridge.cpp:313:  One line control clauses should
not use braces.  [whitespace/braces] [4]
WebKit/chromium/src/ChromiumBridge.cpp:315:  One line control clauses should
not use braces.  [whitespace/braces] [4]
Total errors found: 16

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.