[Webkit-unassigned] [Bug 32953] [Qt] Qt DRT: respect window.close() and window.closed()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32953


Simon Hausmann <hausmann at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45661|review?                     |review-
               Flag|                            |




--- Comment #11 from Simon Hausmann <hausmann at webkit.org>  2009-12-30 06:46:07 PST ---
(From update of attachment 45661)

> +    // It is possible that we get called by windows created from the main page that have finished
> +    // loading, so we don't ASSERT here. At the moment we do not gather results from such windows,
> +    // but may need to in future.
> +    if (!(sender() == m_topLoadingFrame->page()))
> +      return;

The change looks very good to me, but please change the above to use != instead
of !(... == ...) :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.