[Webkit-unassigned] [Bug 32519] mouseEvent fires mutiple times in LayoutTests/svg/custom/use-instanceRoot-as-event-target.xhtml

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 16:39:11 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32519





--- Comment #15 from Robert Hogan <robert at roberthogan.net>  2009-12-29 16:39:10 PST ---
(In reply to comment #14)
> notifyDone() does cause the testing to end right then.  If it doesn't for the
> Qt DRT, then that's a bug.  We might need to better document what notifyDone()
> does.

In this case I think that the DRT sticking around for all output reveals that
the test is actually failing. The detail for the penultimate test is "Test #9:
Verify that the original click event listener got removed and a new one
attached to the use root SVGElementInstance". If you remove one of the lines
that set up test 9:

rectElement.removeEventListener("click", eventHandler, false);
//useElement.instanceRoot.addEventListener("click", eventHandler, false);

it still passes, when it shouldn't. Because the last few tests depend on
adding/removing 'click' events, and removing the click event defined in markup
has no effect, the 'click' event ends up firing multiple times for each click -
when the test comes to an end, the event handler function in the test is still
processing the events and sends them all to the last test in the script:

function eventHandler(evt)
{
    if (evt.type != nextEventType)
        return;
    currentEvent = evt;
    eval(eventNotification);
}

Modiying the above as follows also 'fixes' the test by choking off these
surplus events that shouldn't be happening.

function eventHandler(evt)
{
    if (evt.type != nextEventType)
        return;
    nextEventType = undefined;
    currentEvent = evt;
    eval(eventNotification);
}

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list