[Webkit-unassigned] [Bug 23556] On RTL pages, horizontal scrollbar is missing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23556


Maciej Stachowiak <mjs at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #43559|review?                     |review-
               Flag|                            |




--- Comment #20 from Maciej Stachowiak <mjs at apple.com>  2009-12-29 04:44:16 PST ---
(From update of attachment 43559)
Please try to pare down the comments. It's not necessary to have a comment
(often lengthy) every time int m_rtlMinChildPosition appears. This hurts
readability. Try to limit your comments to saying *why* the code is doing
something, rather than *what* it is doing. "what" should be apparent from the
code. I also agree with Jeremy's comment that the "less than or equal to 0"
condition is best documented with an ASSERT, in which case I expect the
multiple comments explaining that it is less than or equal to 0 are not
necessary.

r- to clean this up. The change otherwise looks ok to me, assuming it matches
what other browsers do, but it may help to have a rendering expert chime in.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.