[Webkit-unassigned] [Bug 32963] buildfix for ResourceHandleWin.cpp

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 29 00:14:54 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32963


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45527|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #8 from Eric Seidel <eric at webkit.org>  2009-12-29 00:14:54 PST ---
(From update of attachment 45527)
Please explain your changes in the ChangeLog.  There are too many, too
complicated changes for this to be reviewed with such an empty ChangeLog.

For example, why this?
-        if (method() == "POST") {
+        if (request().httpMethod() == "POST") {

And this?
+#ifdef RESOURCE_LOADER_DEBUG
+        char buf[64];
+        _snprintf(buf, sizeof(buf), "Load error: %i\n", error);
+        OutputDebugStringA(buf);
+#endif

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list