[Webkit-unassigned] [Bug 32979] [bzt] Create an ASAD command for uploading a patch

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32979


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45549|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #8 from Eric Seidel <eric at webkit.org>  2009-12-28 08:54:44 PST ---
(From update of attachment 45549)
Seems like we'll want some new class for this:
190         diff = state.get("diff")
 191         if not diff:
 192             diff = self._tool.scm().create_patch()
 193             state["diff"] = diff

Maybe a CachingState?  with a .diff() method?

Or just a .get_cached_value("diff", self._tool.scm().create_patch) command?
Glad to see you've abstracted it at least for this one command.

Looks like an OK start.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.