[Webkit-unassigned] [Bug 32982] plugins/get-url-with-iframe-target.html fails on SnowLeopard (64-bit)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32982





--- Comment #2 from Eric Seidel <eric at webkit.org>  2009-12-28 00:03:58 PST ---
(From update of attachment 45548)
argument name seems superflous:
 73     static NPReason reasonForError(NSError *error);

Can't tell if this spacing is right or wrong, seems like spaces beofre * are
wrong here:
 77     static PassRefPtr<PluginRequest> create(uint32_t requestID,
NSURLRequest *request, NSString *frameName, bool allowPopups)

And here:
 88     PluginRequest(uint32_t requestID, NSURLRequest *request, NSString
*frameName, bool allowPopups)

Or shoudl they be " *" because this is a .mm file?

This looks sane.  Looks like a good change.  I still feel like you probably
want someone who's been in this code before to review it though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.