[Webkit-unassigned] [Bug 32682] [Qt] webkitdirs.pm function checkFrameworks always die()s with an error under Windows

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 24 12:03:14 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32682


Daniel Bates <dbates at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|webkit-unassigned at lists.web |dbates at webkit.org
                   |kit.org                     |




--- Comment #6 from Daniel Bates <dbates at webkit.org>  2009-12-24 12:03:14 PST ---
I'll remove the -x check when I land this.

(In reply to comment #5)
> (From update of attachment 45108 [details])
> I think the code should have a comment about why we have this.  At some level
> the separate -x check isn't even really necessary.  The -e check is most
> important.  If somehow someone has their permissions wrong, I'm not sure we
> need to catch that here.
> 
> I'd just remove the -x check.  Or if you decide to keep it, please add a
> comment about why it's separate from the -e check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list