[Webkit-unassigned] [Bug 32401] ifdefs for FreeBSD/OpenBSD

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32401





--- Comment #15 from Laszlo Gombos <laszlo.1.gombos at nokia.com>  2009-12-24 06:17:03 PST ---
(From update of attachment 45457)
The review flag is not set on the patch even though it seems like it is up for
review.

> Index: WebCore/dom/SelectElement.cpp
> ===================================================================

> -#elif PLATFORM(GTK) || (PLATFORM(CHROMIUM) && PLATFORM(LINUX))
> +#elif PLATFORM(GTK) || (PLATFORM(CHROMIUM) && (PLATFORM(UNIX) && !PLATFORM(DARWIN)))

No need for the extra parenthesis - (PLATFORM(CHROMIUM) && PLATFORM(UNIX) &&
!PLATFORM(DARWIN))

For all changes under WebCore/platform/graphics/skia/*

> -#if defined(__linux__) || PLATFORM(WIN_OS)
> +#if (PLATFORM(UNIX) && !PLATFORM(DARWIN)) || PLATFORM(WIN_OS)

I'm not the best person to comment on this but it looks to me that Skia files
aren't currently built on the Mac for Chromium (see
WebCore/WebCore.gyp/WebCore.gyp and JavaScriptCore/wtf/Platform.h). This makes
the !PLATFORM(DARWIN) guard redundant and potentially allows to get rid of all
the guard conditions here.

> Index: WebCore/loader/CachedFont.cpp
> ===================================================================
> -#if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && (PLATFORM(WIN_OS) || PLATFORM(LINUX))) || PLATFORM(HAIKU) || PLATFORM(WINCE)
> +#if PLATFORM(CG) || PLATFORM(QT) || PLATFORM(GTK) || (PLATFORM(CHROMIUM) && (PLATFORM(WIN_OS) || (PLATFORM(UNIX) && !PLATFORM(DARWIN)))) || PLATFORM(HAIKU) || PLATFORM(WINCE)

Similar comments as above - Could this be simplified to (PLATFORM(CHROMIUM) &&
!PLATFORM(DARWIN)) instead of (PLATFORM(CHROMIUM) && (PLATFORM(WIN_OS) ||
(PLATFORM(UNIX) && !PLATFORM(DARWIN)))) ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.