[Webkit-unassigned] [Bug 32876] HTMLInputElement::valueAsDate getter support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32876


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #12 from TAMURA, Kent <tkent at chromium.org>  2009-12-23 03:30:17 PST ---
I committed the patch as r52524 with some modifications.

Thank you for reviewing.

(In reply to comment #8)
> In general, for times WTF and WebCore use doubles that are in seconds since the
> Unix epoch. I probably would suggest that ISODateTime do the same thing, and
> then have the valueAsDate function multiply by 1000, because it's HTML5 that
> does things in milliseconds. I like how the other code uses seconds, because
> that works well with world standards. Things like milliseconds and microseconds
> are derived from the base unit, "second". And I like having only one type of
> time.

The comment is understandable, but I didn't change so.
I feel the merit of the only-one-time-type for WebKit developers is not more
important than the millisecond precision for world-wide users.
And Date in V8 supports millisecond precision.

> I'm not so happy with the term "total millisecond". I see how it came from the
> fact that the millisecond part of the ISODateTime was in a field named
> "millisecond". But if I wanted to use the word total I would probably call it
> "total in milliseconds". I'm not sure I'd use "total" to mean the entire date.
> Note that the comment above about using seconds instead. I think a better term
> for the function would probably be secondsSinceEpoch(). Or if you really want
> to have the 1000 multiplier then I'd call it millisecondsSinceEpoch().

Ok, I renamed it to millisecondsSinceEpoch().

> The enum in ISODateTime should just be called Type since it is a member of
> ISODateTime. If it was at namespace scope, then DateTimeType would be a good
> name for it.

Renamed to just `Type'.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.