[Webkit-unassigned] [Bug 30304] struct RGBA32Buffer is twice as big as the old ImageData of Qt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30304


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #42028|review?                     |review-
               Flag|                            |




--- Comment #26 from Eric Seidel <eric at webkit.org>  2009-12-22 16:28:52 PST ---
(From update of attachment 42028)
I don't see why rect is non-const to begin with.  If I were writing this code,
I would have written:

const IntRect& rect = m_rects[frameIndex];
in the first place.

this change has been aroudn a while and no one has r+'d it, so I guess I'll
express an opinion and mark it r- as unecessary.  Sorry that you seem to have
stepped into a style land-mine on this bug.  I'm not going to argue with
someone else if they chose to r+ this patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.