[Webkit-unassigned] [Bug 32852] New: Use ASSERT instead of assert in image-decoders

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32852

           Summary: Use ASSERT instead of assert in image-decoders
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Other
        OS/Version: Other
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Images
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: kwangyul.seo at gmail.com


RVCT can't compile PNGImagerDecoder.cpp with the following compile error:

[1570/1814] cxx: WebCore\platform\image-decoders\png\PNGImageDecoder.cpp ->
build\default\WebCore\platform\image-decoders\png\PNGImageDecoder_1.o
"..\WebCore\platform\image-decoders\png\PNGImageDecoder.cpp", line
295: Error:  #20: identifier "assert" is undefined
     assert(channels == 3 || channels == 4);
     ^
..\WebCore\platform\image-decoders\png\PNGImageDecoder.cpp: 0 warnings, 1 error
Waf: Leaving directory `C:\cygwin\home\skyul\WebKit\build'
Build failed
 -> task failed (err #1):
       {task: cxx PNGImageDecoder.cpp -> PNGImageDecoder_1.o}

After I changed #include "assert.h" to #include <assert.h>, I could compile the
file without this error. I am not sure if this is a real RVCT bug. However, it
seems that other decoders (BMP, GIF, ICO and XBM) use WTF's ASSERT macro
instead of assert, so I suggest to change the remaining asserts in
PNGImageDecoder.cpp and JPEGImageDecoder.cpp to ASSERT.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.