[Webkit-unassigned] [Bug 32700] WebSocket: Invalid url should raise SYNTAX_ERR exception.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32700


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45258|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #12 from Alexey Proskuryakov <ap at webkit.org>  2009-12-21 09:28:44 PST ---
(From update of attachment 45258)
> +static WebCore::String encodeProtocolString(const WebCore::String& protocol)

This is inside namespace WebCore, and doesn't need namespace prefixes. Please
fix before landing.

> +    const UChar* characters = protocol.characters();
> +    StringBuilder builder;
> +    for (size_t i = 0; i < protocol.length(); i++) {
> +        if (characters[i] < 0x20 || characters[i] > 0x7E)

Why not just use protocol[i]?

r=me

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.