[Webkit-unassigned] [Bug 32819] Review the tooltip implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 21 04:38:06 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32819


WebKit Review Bot <webkit.review.bot at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |webkit-bot-watchers at googleg
                   |                            |roups.com,
                   |                            |webkit.review.bot at gmail.com




--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com>  2009-12-21 04:38:06 PST ---
Attachment 45324 did not pass style-queue:

Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
WebKit/gtk/webkit/webkitwebview.cpp:2634:  Missing space after , 
[whitespace/comma] [3]
WebKit/gtk/webkit/webkitwebview.cpp:2635:  webkit_web_view_query_tooltip is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebKit/gtk/webkit/webkitwebview.cpp:2686:  Missing space after , 
[whitespace/comma] [3]
WebKit/gtk/webkit/webkitwebview.cpp:2687:  Use 0 instead of NULL. 
[readability/null] [5]
WebKit/gtk/webkit/webkitwebview.cpp:2689:  Use 0 instead of NULL. 
[readability/null] [5]
WebKit/gtk/webkit/webkitwebview.cpp:4045:  webkit_web_view_set_tooltip_text is
incorrectly named. Don't use underscores in your identifier names. 
[readability/naming] [4]
WebKit/gtk/webkit/webkitwebview.cpp:4052:  Use 0 instead of NULL. 
[readability/null] [5]
Total errors found: 7

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list