[Webkit-unassigned] [Bug 32813] Type=number UI part 2: Mac implementation of spin-button

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32813


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45318|                            |review?
               Flag|                            |




--- Comment #1 from TAMURA, Kent <tkent at chromium.org>  2009-12-21 03:04:27 PST ---
Created an attachment (id=45318)
 --> (https://bugs.webkit.org/attachment.cgi?id=45318)
Proposed patch

(In reply to comment #0)
> Why have this big function if you're only going to return 0?
> +const int* stepperMargins(NSControlSize controlSize)
> +{
> +    static const int margins[3][4] = {
> +        {0, 0, 0, 0},
> +        {0, 0, 0, 0},
> +        {0, 0, 0, 0}

I followed other similar functions in this file. I removed it in the updated
patch.

> No need:
> +    static NSStepperCell* cell;
> +    if (!cell) {
> +        cell = [[NSStepperCell alloc] init];
> +    }
> Just do:
> static NSStepperCell* cell = [[NSStepperCell alloc] init];

Fixed.

> Needs { } due to the comment:
> +    if (states & PressedState && states & SpinUpState)
> +        // FIXME: There is no way to draw a NSSteperCell with the up button
> hilighted.
> +        // Disables the hilight of the down button if the up button is
> pressed.
> +        [cell setHighlighted:NO];

Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.