[Webkit-unassigned] [Bug 32773] [check-webkit-style] Create a "styles" folder in Scripts/modules

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Dec 20 15:43:53 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32773


Chris Jerdonek <chris.jerdonek at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45299|                            |review?, commit-queue-
               Flag|                            |




--- Comment #12 from Chris Jerdonek <chris.jerdonek at gmail.com>  2009-12-20 15:43:52 PST ---
Created an attachment (id=45299)
 --> (https://bugs.webkit.org/attachment.cgi?id=45299)
Proposed patch

I'm not sure how to proceed with this since it doesn't look like
svn-create-patch supports directory adds.

I would like a directory named "style" added to Scripts/modules.  The
style-related files can be moved/renamed in a subsequent patch.

After the comment discussion with Eric, it definitely seems worth separating
all of the style-related files from the other files in the modules folder, and
not just the style-related files having to do with file types (cpp_style.py,
text_style.py, etc).  And because there are only around 6 style-related files
in all, it doesn't seem necessary to create an additional sub-folder inside for
the file types.  That can always be done later, if necessary.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list