[Webkit-unassigned] [Bug 32801] New: Always allow zooming in/out standalone images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32801

           Summary: Always allow zooming in/out standalone images
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: Images
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: msanchez at igalia.com


DESCRIPTION:

Currently the ShrinksStandaloneImagesToFit setting in WebCore::Settings
controls two things at the same time:

  - Whether an standalone image should show up automatically resized to window
size when loaded
  - Whether it's possible to zoom in (and out) the image by clicking on top of
it

So, if you now set that setting to 'true' you'll get that all standalone images
will appear shrunk to window size by default, and clicking on them will enlarge
them. However if you set it to 'false' the image will appear in 1:1 ratio *and*
clicking on top of it will get no effect (no zoom out as the handler won't be
even installed).

This means so far it's impossible to render standalone images to the 1:1 ratio
by default while still being able to click on top of them to zoom in/out the
image, as using 'true' will shrink by default and using 'false' will not
install the mouse click handler for that.

Check epiphany bug 599997 for more details about the motivation of this bug
(https://bugzilla.gnome.org/show_bug.cgi?id=599997)

PROPOSAL:

Basically I'd see two ways to fix this:

  1. Keep the same meaning for ShrinksStandaloneImagesToFit values and just
*add a new setting* to control the initial status of an image when shrinking is
activated: initially shrink it or not.

  2. Change the meaning of ShrinksStandaloneImagesToFit setting so it would
control *only* whether the image is initially shrank or not, having the handler
for the zoom in/out thing always installed.


The main advantage of (1) is that it doesn't affect to the behaviour of already
existing applications, just extends the possibilities with a new setting (but
adding a new setting could be seen as a disavantage also).

The main advantage of (2) is that it would keep things more simple, although it
would be needed to take the change into account in already existing apps, and
it would make impossible to disable the zoom.

I have patches for both the two possibilities but I'm not sure which one is the
most correct one bearing in mind all the platforms, so opinions? (I'll attach
patches right away)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.