[Webkit-unassigned] [Bug 32080] Make it possible to keep track of scrolls

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32080


Adam Treat <treat at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44169|review?                     |review-
               Flag|                            |




--- Comment #7 from Adam Treat <treat at kde.org>  2009-12-20 08:14:05 PST ---
(From update of attachment 44169)
> This patch makes sure that there is no behaviour change for Haiku.
...
> +bool ChromeClientHaiku::scroll(const IntSize& scrollDelta, const IntRect& rectToScroll, const IntRect& clipRect, bool canBlit)
>  {
>      notImplemented();
> +    return true;

There is a behavior change here.  Haiku previously would have repainted the
entire viewport for a slow scroll.  Now it won't since it returns true
indicating it 'canBlit'.

> This patch makes sure that there is no behaviour change for Mac.
...
> -void WebChromeClient::scroll(const IntSize&, const IntRect&, const IntRect&)
> +bool WebChromeClient::scroll(const IntSize&, const IntRect&, const IntRect&, bool)
>  {
> +    return true;
>  }

There is a behavior change here.  Mac previously would have repainted the
entire viewport for a slow scroll.  Now it won't since it returns true
indicating it 'canBlit'.

You don't need to add a bool return value to scroll IMHO.  I'd prefer you add a
new 'slowScroll' notification to the various ChromeClient's instead of doing it
this way.

r- for the behavior changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.