[Webkit-unassigned] [Bug 32780] Use memcache to make dashboard to fast

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 19 22:57:00 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32780


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45255|review?                     |review+
               Flag|                            |




--- Comment #3 from Eric Seidel <eric at webkit.org>  2009-12-19 22:56:59 PST ---
(From update of attachment 45255)
remove_api seems unrelated.

I don't see why you broke queue_name and bug_id out into local variables in
UpdateStatus

Why change it to use a regexp if we compile every time?
74         regexp = re.compile("-")
 75         return regexp.sub("_", dashed_name)

replace is simpler, no?

Why do we have 3 copies of the string "attachment-summary"?  Seems error prone.

Looks OK though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list