[Webkit-unassigned] [Bug 32778] New: Fix Perl equality warning in run-webkit-tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 19 16:07:28 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32778

           Summary: Fix Perl equality warning in run-webkit-tests
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Windows XP
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: dbates at webkit.org
                CC: eric at webkit.org, aroben at apple.com,
                    bweinstein at apple.com


Notice the variable $diffPercentage is initialized to be an empty string on
line 711
<http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests?rev=52296#L711>.

But on line 770
<http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/run-webkit-tests?rev=52296#L770>
we perform a numerical equality test (==). Instead, we should be performing a
string equality test (eq). Otherwise, Perl may throw the following warning:

Argument "" isn't numeric in numeric eq (==) at
WebKitTools/Scripts/run-webkit-tests line 770.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list