[Webkit-unassigned] [Bug 32773] [check-webkit-style] Create a "styles" folder in Scripts/modules

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 19 11:29:25 PST 2009


--- Comment #10 from Eric Seidel <eric at webkit.org>  2009-12-19 11:29:24 PST ---
(In reply to comment #8)
> If you're going to be doing some removes/renames, I know that Darin had some
> opinions about using the name "bugzilla":
> https://bugs.webkit.org/show_bug.cgi?id=32542#c3

His comments appear unrelated.  bugzilla.py is the module which knows how to
talk to a bugzilla instance.  We could create a bugs.py with an abstract
interface if we ever wanted to have a radar.py (apple's bug database) or some
other bug database.  tool.bugs was named bugs instead of bugzilla with exactly
this in mind.

> Something else to think about.  It might be nice if, for example,
> run-webkit-unittests didn't need to get updated each time a new file was added
> to the style code.  So perhaps in the new scheme each module like the
> style-checker could have a single master unit test file that
> run-webkit-unittests would import.

This is easily solved using __ALL__ in the __init__.py files.  Adam and I just
haven't quite gotten there yet.  Our python-fu is strong, but not quite that
strong yet. :)

I believe we could just use from modules import * and it would all "just work"

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list