[Webkit-unassigned] [Bug 32718] Reduce #includes in a few high-use headers

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32718


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|Other                       |All
         OS/Version|Mac OS X 10.5               |All




--- Comment #6 from Adam Roben (aroben) <aroben at apple.com>  2009-12-18 09:41:02 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 45156 [details] [details])
> > > +namespace JSC {
> > > +class UString;
> > > +}
> > 
> > We normally indent the things inside namespace when doing such forward
> > declarations.
> 
> I waffled over that. I looked through WebCore and didn't see a clearly
> prevailing style, and our style guidelines don't mention this situation.

More accurately: I didn't see a clearly prevailing style *among files that
don't indent within the WebCore namespace*. Among files that do indent within
the WebCore namespace, indenting within other namespaces was (nearly?) always
done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.