[Webkit-unassigned] [Bug 32638] [V8] V8CustomBinding.h should vanish.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32638


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abarth at webkit.org




--- Comment #4 from Adam Barth <abarth at webkit.org>  2009-12-17 22:29:36 PST ---
+ static v8::Handle<v8::Value> ${name}Callback(const v8::Arguments&);

Is this adding static declarations to a header file?  Maybe this is part of a
class?  But the indent is only two spaces...  Can you attach a sample generated
file?

+ class V8HTMLPlugInElement {
+   public:

The public should be indented zero spaces.  You can catch this kind of stuff by
running check-webkit-style.  (The stylebot would have caught it if the patch
applied to TOT).

+ ACCESSOR_GETTER(ClipboardTypes)

I don't understand the diff for this function.

- for (HashSet<String>::const_iterator it = types.begin(); it != end; ++it,
++index)
+ for (HashSet<String>::const_iterator it = types.begin(); it != end; ++it,
index)

Notice that you lost the "++" before index.  Intensional?

Other than that, looks great!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.