[Webkit-unassigned] [Bug 32452] Port of v8 to work with Gtk webkit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 17 15:19:07 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32452





--- Comment #26 from Michael Emmel <mike.emmel at gmail.com>  2009-12-17 15:19:05 PST ---

Hmm no feedback.

I'm now working on a proposed refactoring of the GNUMakefile to make them
easier to modify more flexible. This will result in two patches. One showing
the reorganization and the second with the actual v8 changes applied.

Hopefully this makes it easier to manage optional parts of the build for Gtk.
The assumption is the v8 option is probably the most aggressive change therefor
if I can reorg where clean patches are easy to create for new features then its
a useful change.

Next assuming no other feedback I'll attempt to create at least a partial
alternative path using undef to try and include v8 headers without renaming.
The only obvious way I can think to do this is to wrap the offending native
headers with one that does the undefs. This is the approach used inside WebKit
in

npruntime_internal.h

So I'll create gtk_internal.h cairo_internal.h etc and see what happens.
Of course this was the approach I took originally before giving up but I don't
see I have much choice but to offer a sample patch. There is a chance since I
now have a functional build using renaming that I can find a simple way to
remove renaming. Where when I first was trying to port all the other issues
made it hard to come up with a clean approach.

Best case is it works worst case is at least I can provide a patch to help
highlight the issues.

I'm certainly open to feedback and suggestions lacking that I'll do my best to
try and present the alternatives.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list