[Webkit-unassigned] [Bug 32674] Fix link failure on LTCG builds on Windows for chromium port

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32674


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45092|review?                     |review+
               Flag|                            |




--- Comment #6 from Eric Seidel <eric at webkit.org>  2009-12-17 11:04:20 PST ---
(From update of attachment 45092)
Do we have a build-bot which uses this (or that will), otherwise this will
certainly break again.

This is kinda an ugly fix, but that's because any of the AllInOne filese are
kinda hacks.  What is a LTCG build?  Why should we be prefixing the SVGNames
which conflict with HTMLNames instead of the reverse?

It seems that at least some of these changes need comments.  Like the naming of
mapSvgAttributeToCSSProperty should have a comment.  maybe we should just share
that code using StyledElement.h/StyledElement.cpp instead of renaming our copy?
 Or does the copy actually do something different in the SVG case?

This looks fine, but would be nice to hear answers to above before landing.

Better to leave the "Reviewed by" line as the default "Reviewed by
NOBODY(OOPS!)" because our scripts like svn-apply, the commit-queue and normal
bugzilla-tool land-diff/land-patches know how to fix that up with the proper
reviewer from the bug anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.