[Webkit-unassigned] [Bug 32597] Check one space before end of line comments

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32597


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45043|review?                     |review-
               Flag|                            |




--- Comment #14 from David Levin <levin at chromium.org>  2009-12-17 10:05:34 PST ---
(From update of attachment 45043)
Shinichiro did a fine job of reviewing this patch.

r- for the removed test cases that Shinichiro noted.

One small additional comment below.

> diff --git a/WebKitTools/Scripts/modules/cpp_style.py b/WebKitTools/Scripts/modules/cpp_style.py
> +                and ((line[comment_position-1] not in string.whitespace)
> +                     or (line[comment_position-2] in string.whitespace)))):

I know this was a problem before but since you are changing these lines please
add spaces around the "-".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.