[Webkit-unassigned] [Bug 32663] Don't include all JSC headers everywhere

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32663


Adam Roben (aroben) <aroben at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45070|review?                     |review+
               Flag|                            |




--- Comment #3 from Adam Roben (aroben) <aroben at apple.com>  2009-12-17 08:17:43 PST ---
(From update of attachment 45070)
> -#if USE(JSC)
> -#include <runtime/Identifier.h>
> -#else
> -// runtime/Identifier.h brings in a variety of wtf headers.  We explicitly
> -// include them in the case of non-JSC builds to keep things consistent.
>  #include <wtf/HashMap.h>
>  #include <wtf/HashSet.h>
>  #include <wtf/OwnPtr.h>
> -#endif

I think it's worth adding a FIXME here saying that we shouldn't #include these
headers, either, unless absolutely necessary.

r=me, but commit-queue- so you can consider adding the FIXME.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.