[Webkit-unassigned] [Bug 32663] Don't include all JSC headers everywhere

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 17 08:02:47 PST 2009


https://bugs.webkit.org/show_bug.cgi?id=32663


Benjamin Otte <otte at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #45070|                            |review?, commit-queue?
               Flag|                            |




--- Comment #1 from Benjamin Otte <otte at gnome.org>  2009-12-17 08:02:42 PST ---
Created an attachment (id=45070)
 --> (https://bugs.webkit.org/attachment.cgi?id=45070)
patch

PlatformString.h included almost all of JSC via runtime/Identifier.h. This
patch gets rid of this include by forward-declaring the required classes
instead.
This reduces the build size of the object files on a Gtk debug build by 10%.
The resulting libwebkit.so gets 5% smaller.

Somebody should probably make sure it still compiles on mac and qt as
PlatformString.h pulled a lot of other headers that must now be included
manually (like the one math.h fix for Gtk I have in the patch).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list