[Webkit-unassigned] [Bug 32596] Refactor Window object tests to use a shared list of property names

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32596





--- Comment #12 from Kent Hansen <kent.hansen at nokia.com>  2009-12-17 05:31:01 PST ---
(In reply to comment #7)
> (From update of attachment 44945 [details])
> What this removes is any test that checks that no extra properties on the
> Window object are present. I would like to see us add one test for that. It's
> good not to have multiple tests for it, but I think it's good to have one to
> help remind people to keep the list of window properties up to date. That test
> can have whatever platform exceptions we need coded into it.

Well, fast/dom/Window/get-set-properties will fail when new properties are
added, so people will still need to update that test.
But you're right, there's no hint that you perhaps need to update the shared
list of properties too, which means the list can rot (which is what's happened
already, since I had to add a ton of missing properties to make this patch
work).
Like Eric suggested in https://bugs.webkit.org/show_bug.cgi?id=28771, ideally
the list should be auto-generated (from DOMWindow.idl?).

> 
> > -FAIL inner.isInner.isInner should be true. Was false.
> > -FAIL inner.isInner.constructor.isInner should be true. Was false.
> 
> Is it a good thing to skip testing this? Should we add something back so this
> case is tested?

As I understand it, the purpose of the prototype-inheritance test is to test
properties of the Window object itself, not properties inherited from
Object.prototype (the subject of the bug for which the test was added is "Some
constructor objects exposed on Window have the wrong prototype chain"). The
isInner property can of course be injected into the property list to keep the
above expected test output, but I'd prefer making a separate test if it's
important. Maybe Eric can comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.