[Webkit-unassigned] [Bug 32538] [check-webkit-style] Add support for TAB check against text files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32538





--- Comment #18 from TAMURA, Kent <tkent at chromium.org>  2009-12-16 21:19:39 PST ---
(In reply to comment #14)
(In reply to comment #15)
(In reply to comment #16)

Thank you for the comments.

* I fixed all of typos.

* As for code sharing with cpp_style.py, I have added FIXME comments for now.

> > +    return ("ChangeLog" in filename
> > +            or "WebKitTools/Scripts/" in filename
> > +            or extension in ('.css', '.html', '.idl', '.js', '.mm', '.php', '.pm', '.py', '.txt'))
> 
> Please make this *not handle* files in the LayoutTest directory. TABs, while
> infrequent, are allowed in js and html files there. (Tabs in the files there
> ensure that the js and html parsing handle them correctly.)

I see. I changed it so that "LayoutTests/*" is excluded.
But I want files in LayoutTests are also checked. I'll investigate whether
CSS/HTML/JS parsing tests are put into specific directories or not.

> Also, please consider adding your new unit test files to
> WebKitTools/Scripts/run-webkit-unittests and fixing the nits below.

Added.

I'll commit the change manually.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.