[Webkit-unassigned] [Bug 32249] WebSocket test server handshake is not strict enough

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=32249


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #44948|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #17 from Alexey Proskuryakov <ap at webkit.org>  2009-12-16 09:58:05 PST ---
(From update of attachment 44948)
 +    r'(WebSocket-Protocol: [\x20-\x7e]+\r\n)?'
> +    r'([Cc][Oo][Oo][Kk][Ii][Ee]:[^\r]*\r\n)*'
> +    r'([Cc][Oo][Oo][Kk][Ii][Ee]2:[^\r]*\r\n)?'
> +    r'([Cc][Oo][Oo][Kk][Ii][Ee]:[^\r]*\r\n)*'

You didn't address my comment about Cookie headers also being in restricted
WebSocket syntax. Like other headers, they are case sensitive, require one
space after colon, etc.

This doesn't correctly handle the case of multiple Cookie headers - that
deserves at least a FIXME comment, if not fixing right away.

> -      version='0.4.3',
> +      version='0.4.5',

ChangeLog should be fixed to say 0.4.5.

> MUST level applies for the way the client sends data, but not for the way the
> server examine the data.

Ok.

r=me. ChangeLog will need to be fixed when landing, and please consider further
improving Cookie handling in a future patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.