[Webkit-unassigned] [Bug 31187] Get rid of phase argument to Image::drawPattern

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31187





--- Comment #6 from Darin Adler <darin at apple.com>  2009-12-16 09:41:17 PST ---
(From update of attachment 44979)
This looks like a good idea to me.

> +    TransformationMatrix patternTransform = TransformationMatrix();
> +    patternTransform.translate(oneTileRect.x(), oneTileRect.y());
> +    patternTransform.scaleNonUniform(scale.width(), scale.height());

> +    TransformationMatrix patternTransform = TransformationMatrix().translate(dstRect.x() - hPhase, dstRect.y() - vPhase).scaleNonUniform(scale.width(), scale.height());

Why the different idiom at these two call sites? I think you should choose one
style or the other.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.